View Issue Details

IDProjectCategoryView StatusLast Update
0001578T99X171.00 SKB EaglexTS certificationpublic2023-03-06 10:59
Reporter(SW) Jason LingAssigned To(SW) Jason LingDue Date
PrioritynormalSeveritys4-minorReproducibilityalways
Status closedResolutionfixed 
Summary0001578: [Smart3][ATV12] side effect of webviewprovider
DescriptionHi YK,

We have one GTS failure as bellows,
run gts -m GtsWebViewTestCases -t com.google.android.webview.gts.WebViewTest#testWebViewFrameworkConfigSettingIsSet

After we revert the following commit and use Standard Launcher, we can pass it.

vendor/google_gtvs
Added overlay for skb webview (webview.jpg)

please check it with SPTEK.

Thanks,
Jason
TagsNo tags attached.
Attach Tags

Activities

(SW) Jason Ling

2022-12-16 21:12

developer  

webview.jpg (475,024 bytes)

(ALTech) Younkwang Jung

2022-12-19 08:39

developer   ~0011504

Hi Jason

I reported it to SPTEK
https://jira.skbroadband.com/browse/FSTB12-16

I will let you know when I get feedback

Thank you
YK.Jung

(ALTech) Younkwang Jung

2022-12-19 15:42

developer   ~0011520

Hi Jason

SKB and SPTEK will check the contents of this fail item.

Please share the the test sheet and the log.

Thank you
YK.Jung

(SW) Jason Ling

2022-12-19 18:14

developer   ~0011523

Hi YK,

Please refer to attachment.

Thanks,
Jason
result.jpg (247,858 bytes)   
result.jpg (247,858 bytes)   

(ALTech) Younkwang Jung

2022-12-20 12:07

developer   ~0011530

Last edited: 2022-12-20 12:13

View 2 revisions

Hi Jason

GTS Test Suite version is 10_r2.
Did you the test with Android 12 test tool?
It seems to be a FAIL entry for the WebView package version, and SKB think Test Suite for Android 12 needs to confirm that it's the same result.
===========================================
com.google.android.webview.gts.WebViewTest#testWebViewFrameworkConfigSettingIsSet FAILURE: java.lang.AssertionError: Wrong number of WebView implementation packages. expected: <6> but was:<7>
===========================================

Thank you!!
YK.Jung

(SW) Jason Ling

2022-12-20 14:39

developer   ~0011532

Hi YK,

I use the correct tool, please refer the attachment (gts-tool)

Thanks,
Jason
gts-tool.png (10,441 bytes)   
gts-tool.png (10,441 bytes)   

(ALTech) Younkwang Jung

2022-12-21 15:35

developer   ~0011541

Hi Jason

The reason for this error is that there should be 6 providers, but SPTEK added 1 more.

You can check the provider in the file below
xml path is vendor/google_gtvs/overlay/GoogleWebViewOverlay/res/

So, in order to pass this test, we need to remove one other provider.
but SPTEK cannot run the GTS test.
So please check which provider can be deleted and apply it.

Thank you
YK.Jung
webview.PNG (249,164 bytes)   
webview.PNG (249,164 bytes)   

(SW) Jason Ling

2022-12-23 09:20

developer   ~0011554

HI YK,

I've seen that SPTEK remove AOSP webview provider.
After we testing this modification, the items still fail, Please check webviewprovider1222.jpg

The test tool will check that the number of providers must be 6 and every webview provider should be present and in the correct order.
(SPTEK can not add/remove any webviewprovider).

Thanks,
Jason
webviewprovider1222.jpg (157,203 bytes)   
webviewprovider1222.jpg (157,203 bytes)   

(ALTech) Younkwang Jung

2022-12-23 09:42

developer   ~0011555

Hi Jason

Could you share the source code of the test tool?
"the code to check the number of providers and the order"

I have reported this issue to SKB/SPTEK as an urgent issue now.

Thank you
YK.Jung

(ALTech) Younkwang Jung

2022-12-23 10:05

developer   ~0011556

Hi Jason

Is there any way SPTEK can test this GTS item with ND FW?

Thank you
YK.Jung

(SW) Jason Ling

2022-12-23 10:57

developer   ~0011558

Last edited: 2022-12-23 11:02

Hi YK,

We don't have source code of GTS, we use reverse engineering to check this test function
The default 6 webviewproviders will be put in Array "WEBVIEW_PROVIDERS_Q_AND_LATER "

Please refer to testWebViewFrameworkConfigSettingIsSet function (CheckEveryWebView.jpg)

By the way, In Android P, the TVStorm has GTS Tool, so I don't know why SPTEK doesn't have GTS tool.
I think if SPTEK has GTS tool, they can use ND F/W to verify it.

Thanks,
Jason
6_webviewprovider.jpg (783,406 bytes)
CheckEveryWebView.jpg (346,978 bytes)

(ALTech) Younkwang Jung

2022-12-26 10:06

developer   ~0011566

HI Jason

STPEK does not have a GTS tool.
If STPEK make ND FW, can you verify it?

Thank you
YK.Jung

(SW) Jason Ling

2022-12-26 11:30

developer   ~0011569

Hi YK,

OK, Please give us ND image

Thanks,
Jason

(ALTech) Younkwang Jung

2023-01-06 11:55

developer   ~0011687

Hi Jason

SPTEK says this issue has been fixed.
Please do the test again

Thank you
YK.Jung

(SW) Sam Yang

2023-01-13 17:08

developer   ~0011774

Hi YK,

It is fixed, thanks~

(SW) Jason Ling

2023-01-16 11:47

developer   ~0011790

Hi YK,

SPTEK's new solution will have another side effect

run gts -m GtsPlacementTestCases -t com.google.android.placement.gts.CoreGmsAppsTest#testCustomizedWebviewPreloaded

java.lang.AssertionError: Only Google prebuilt webview is allowed , but customized webiews are found:
com.android.webview
    at org.junit.Assert.fail(Assert.java:89)
    at org.junit.Assert.assertTrue(Assert.java:42)
    at com.google.android.placement.gts.CoreGmsAppsTest.testCustomizedWebviewPreloaded(CoreGmsAppsTest.java:625)

Thanks,
Jason

(SW) Jason Ling

2023-01-16 11:47

developer   ~0011791

(ALTech) Younkwang Jung

2023-01-16 14:00

developer   ~0011797

Hi Jason

If you have more information about this test, please share it with me.
There is no information because SPTEK cannot run GTS.

Thank you
YK.Jung

(SW) Jason Ling

2023-01-16 15:25

developer   ~0011799

Hi YK,

We don't have source code of GTS, we use reverse engineering to check this test function
Please refer to testCustomizedWebviewPreloaded.jpg

It looks like if SPTEK changes the package name of their webview app, we can pass this item.

Thanks
Jason

(SW) Sam Yang

2023-01-31 19:26

developer   ~0011921

Confirm with version "537r03".

Issue History

Date Modified Username Field Change
2022-12-16 21:12 (SW) Jason Ling New Issue
2022-12-16 21:12 (SW) Jason Ling Status new => assigned
2022-12-16 21:12 (SW) Jason Ling Assigned To => (ALTech) Younkwang Jung
2022-12-16 21:12 (SW) Jason Ling File Added: webview.jpg
2022-12-16 21:12 (SW) Jason Ling Description Updated
2022-12-16 21:12 (SW) Jason Ling Issue Monitored: (SW) Kerwin Chen
2022-12-19 08:38 (ALTech) Younkwang Jung Issue Monitored: (ALTech) SY Yoon
2022-12-19 08:38 (ALTech) Younkwang Jung Issue Monitored: (ALTech) JunGyu Kim
2022-12-19 08:39 (ALTech) Younkwang Jung Note Added: 0011504
2022-12-19 15:42 (ALTech) Younkwang Jung Note Added: 0011520
2022-12-19 18:14 (SW) Jason Ling Note Added: 0011523
2022-12-19 18:14 (SW) Jason Ling File Added: result.jpg
2022-12-19 18:14 (SW) Jason Ling File Added: testWebViewFrameworkConfigSettingIsSet-log.zip
2022-12-20 12:07 (ALTech) Younkwang Jung Note Added: 0011530
2022-12-20 12:13 (ALTech) Younkwang Jung Note Edited: 0011530 View Revisions
2022-12-20 14:39 (SW) Jason Ling Note Added: 0011532
2022-12-20 14:39 (SW) Jason Ling File Added: gts-tool.png
2022-12-21 15:35 (ALTech) Younkwang Jung Note Added: 0011541
2022-12-21 15:35 (ALTech) Younkwang Jung File Added: webview.PNG
2022-12-22 09:10 (ALTech) Younkwang Jung Issue Monitored: (ALTech) Younkwang Jung
2022-12-23 09:20 (SW) Jason Ling Note Added: 0011554
2022-12-23 09:20 (SW) Jason Ling File Added: webviewprovider1222.jpg
2022-12-23 09:42 (ALTech) Younkwang Jung Note Added: 0011555
2022-12-23 10:05 (ALTech) Younkwang Jung Note Added: 0011556
2022-12-23 10:57 (SW) Jason Ling Note Added: 0011558
2022-12-23 10:57 (SW) Jason Ling File Added: 6_webviewprovider.jpg
2022-12-23 10:57 (SW) Jason Ling File Added: CheckEveryWebView.jpg
2022-12-23 11:02 (SW) Jason Ling Note Edited: 0011558
2022-12-26 10:06 (ALTech) Younkwang Jung Note Added: 0011566
2022-12-26 11:30 (SW) Jason Ling Note Added: 0011569
2022-12-26 16:14 (SW) Jacky Chiang Issue Monitored: (SW) Jacky Chiang
2023-01-05 20:19 (SW) Jason Ling Category SW Issue => xTS certification
2023-01-06 11:55 (ALTech) Younkwang Jung Note Added: 0011687
2023-01-13 17:08 (SW) Sam Yang Assigned To (ALTech) Younkwang Jung => (SW) Jason Ling
2023-01-13 17:08 (SW) Sam Yang Status assigned => resolved
2023-01-13 17:08 (SW) Sam Yang Resolution open => fixed
2023-01-13 17:08 (SW) Sam Yang Note Added: 0011774
2023-01-16 11:47 (SW) Jason Ling Status resolved => assigned
2023-01-16 11:47 (SW) Jason Ling Resolution fixed => open
2023-01-16 11:47 (SW) Jason Ling Note Added: 0011790
2023-01-16 11:47 (SW) Jason Ling Note Added: 0011791
2023-01-16 11:47 (SW) Jason Ling File Added: testCustomizedWebviewPreloaded.jpg
2023-01-16 13:33 (SW) Jason Ling Issue Monitored: (SW) Sam Yang
2023-01-16 14:00 (ALTech) Younkwang Jung Note Added: 0011797
2023-01-16 15:25 (SW) Jason Ling Note Added: 0011799
2023-01-16 15:25 (SW) Jason Ling File Added: testCustomizedWebviewPreloaded-2.jpg
2023-01-31 19:26 (SW) Sam Yang Status assigned => resolved
2023-01-31 19:26 (SW) Sam Yang Resolution open => fixed
2023-01-31 19:26 (SW) Sam Yang Note Added: 0011921
2023-03-06 10:59 (SW) Jason Ling Status resolved => closed